Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: refactor u_dot parachute method #596

Merged
merged 4 commits into from
May 19, 2024

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (not needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Let's be honest, reading this function isn't that easy.

New behavior

Changes names of variables and avoid some redundant operations.

Breaking change

  • No

Additional information

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (61ebbc7) to head (db9a370).
Report is 25 commits behind head on develop.

Current head db9a370 differs from pull request most recent head 64bdab2

Please upload reports for the commit 64bdab2 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #596      +/-   ##
===========================================
+ Coverage    73.37%   73.38%   +0.01%     
===========================================
  Files           57       57              
  Lines         9453     9461       +8     
===========================================
+ Hits          6936     6943       +7     
- Misses        2517     2518       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rocketpy/simulation/flight.py Outdated Show resolved Hide resolved
rocketpy/simulation/flight.py Show resolved Hide resolved
Base automatically changed from enh/pre-calculate-attributes-in-rocket-class to develop May 16, 2024 22:53
@Gui-FernandesBR
Copy link
Member Author

@phmbressan could you re-approve it please?

@Gui-FernandesBR Gui-FernandesBR merged commit 1e17549 into develop May 19, 2024
8 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/refactor-u-dot-parachute branch May 19, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants