eliminating multiple plots for inertia tensors #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still investigating the reason, but I got this error when running
|
Gui-FernandesBR
requested changes
Mar 4, 2024
There was a problem hiding this comment.
The submitted code in this PR doesn't seem to be working.
@dipesh2212 we should work on
Here are some comments to guide you:
- Try to read @juliomachad0 's solution, you might benefit from his approach in this case.
- The lines like
self.I_11(*self.motor.burn_time)in the motor_plots.py file will no longer work, please update the_MotorPlots.allmethod. - Always run the tests before submitting your code, this prevents you from submitting a code that is not working.
- I think you could easily use the
Function.compare_plotsto easily create a single figure with all the inertia Functions and then display them.
Also, some other "small but important" things that I noticed:
- Rename your PR to start with
ENH:, thus showing clearly the intention of your PR. - Please run black before submitting your code. (see the Makefile in the root directory for more details)
- If possible, please also provides screenshot of the plots you have modified, this allows us to understand what is the expected behavior without needing to run the code on our own.
| def I_23(self, lower_limit=None, upper_limit=None): | ||
| """Plots I_23 of the motor as a function of time. | ||
| for label in labels: | ||
| getattr(self.motor, label).plot( |
There was a problem hiding this comment.
I don't think this will going to work as expected.
- The
Function.plotmethod does not have alabelargument. I think you should use theFunction.plot_1dinstead - This for loop is simply plotting all the curves one by one in different plots, right? Instead, what we expect from this PR is something very similar to this: https://github.com/RocketPy-Team/RocketPy/pull/547/files#
| None | ||
| """ | ||
| self.motor.I_23.plot(lower=lower_limit, upper=upper_limit) | ||
| return fig |
There was a problem hiding this comment.
No need to return the matplotlib fig. Just use the plt.show() instead.
Gui-FernandesBR
added
Motors
Gui-FernandesBR
force-pushed
the
527-eliminating-multiple-plots-for-inertia_tensors
branch
from
4a9912b
to
81e92c6
Compare
…ttps://github.com/RocketPy-Team/RocketPy into 527-eliminating-multiple-plots-for-inertia_tensors
|
A quick update in the function:
I'm getting this result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
Current behavior
There are multiple inertial tensor plots that are being plotted, it is kinda annoying to deal with those
New behavior
I've tried to integrate all the plots in one single plot which can compare the inertia tensor in a convenient way
Breaking change