Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow bot agents to skip the queue #34987

Merged
merged 6 commits into from
Jan 29, 2025
Merged

fix: Allow bot agents to skip the queue #34987

merged 6 commits into from
Jan 29, 2025

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jan 21, 2025

Proposed changes (including videos or screenshots)

We were checking for a bot's capability of skipping queue after checking if waiting queue was enabled (and thus queueing the rooms)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-729

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 408a1a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34987/

Built to branch gh-pages at 2025-01-29 12:15 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (8e2c989) to head (408a1a1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34987   +/-   ##
========================================
  Coverage    59.18%   59.18%           
========================================
  Files         2822     2822           
  Lines        68070    68070           
  Branches     15136    15136           
========================================
  Hits         40284    40284           
  Misses       24956    24956           
  Partials      2830     2830           
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review January 21, 2025 15:49
@KevLehman KevLehman requested review from a team as code owners January 21, 2025 15:49
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jan 28, 2025
@casalsgh casalsgh added this to the 7.4.0 milestone Jan 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 28, 2025
@kodiakhq kodiakhq bot merged commit 893867b into develop Jan 29, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/bots branch January 29, 2025 12:51
@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jan 29, 2025

Pull request #35058 added to Project: "Patch 7.2.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants