feat!: Merge LDAP Teams Sync and Channels Sync into a new Rooms Sync section #32390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
#{groupName}
replacement in the LDAP Sync Rooms "Search Filter" (since the filter is now applied once per user);memberOf
field (RC didn't bind to the admin before applying the LDAP search request to get user groups, so only the logged in user itself would be visible).More details about settings transition to the new organization
LDAP_Sync_User_Data_Channels
LDAP_Sync_User_Data_Rooms
LDAP_Sync_User_Data_Channels_Admin
LDAP_Sync_User_Data_Rooms_Admin
LDAP_Sync_User_Data_Channels_Filter
LDAP_Sync_User_Data_Rooms_Filter
LDAP_Sync_User_Data_Channels_BaseDN
LDAP_Sync_User_Data_Rooms_BaseDN
LDAP_Sync_User_Data_ChannelsMap
LDAP_Sync_User_Data_RoomsMap
LDAP_Sync_User_Data_Channels_Enforce_AutoChannels
LDAP_Sync_User_Data_Rooms_Auto_Leave
LDAP_Teams_Name_Field
LDAP_Group_Name_Field
LDAP_Enable_LDAP_Groups_To_RC_Teams
LDAP_Sync_User_Data_Rooms
instead)LDAP_Groups_To_Rocket_Chat_Teams
LDAP_Sync_User_Data_RoomsMap
instead)LDAP_Validate_Teams_For_Each_Login
LDAP_Validate_Rooms_For_Each_Login
instead)LDAP_Teams_BaseDN
LDAP_Sync_User_Data_Rooms_BaseDN
instead)LDAP_Query_To_Get_User_Teams
LDAP_Sync_User_Data_Rooms_Filter
instead)Settings comparison (before and after):
Caution
Teams sync must be reconfigured using the "Rooms Sync" setting
Channels sync must also be reconfigured in case the
#{groupName}
replacement (which is not supported anymore) was being used -- prefer filtering by themember
attribute in groups instead of using thememberOf
field to avoid this.Issue(s)
Steps to test or reproduce
Demo:
ldap-rooms-sync-test.webm
Further comments
CORE-402