Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: afterTakeInquiry room as required param #32389

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 8, 2024

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-440

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 420167f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (105a1eb) to head (420167f).
Report is 14 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32389      +/-   ##
===========================================
+ Coverage    55.48%   55.56%   +0.07%     
===========================================
  Files         2371     2404      +33     
  Lines        52062    52891     +829     
  Branches     10651    10862     +211     
===========================================
+ Hits         28888    29389     +501     
- Misses       20636    20898     +262     
- Partials      2538     2604      +66     
Flag Coverage Δ
e2e 54.80% <ø> (+0.09%) ⬆️
unit 73.61% <100.00%> (-1.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the refactor/afterTakeInquiry branch from 30bfe53 to 45132f0 Compare May 8, 2024 22:37
@ggazzo ggazzo force-pushed the refactor/afterTakeInquiry branch from 45132f0 to 691fa18 Compare May 8, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant