Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Integration entity out of db watcher #32378

Merged
merged 4 commits into from May 14, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented May 7, 2024

As per the updates mentioned in PROJ-7 SCA-4 and ADR #74, this pull request focuses on relocating Integration entity out of DB Watcher service.

Quick context to public readers

In essence, this modification empowers RocketChat's app to directly call listeners through the api.broadcast global function, eliminating the reliance on MongoDB Change Stream data propagation

Why is this beneficial? It provides better control over notifying users by enabling more precise use-case management. Unlike Change Streams, which notify every action on Mongo's documents and sometimes might result in unnecessary duplicate notifications. Moreover, it contributes to the future removal of the DB Watcher deployment, thereby optimizing resource utilization.

Proposed changes

Key changes include:

  • Conditionally incorporating Permissions entity import within DB watchers on application startup based on the dbWatchersDisabled flag.
  • Enabling support for the following use cases to directly trigger watch.integrations listener event, subject to the dbWatchersDisabled flag.
Updated use cases.
Use Case Route/Trigger Notes
deleteUser Route POST users.delete
updateRoomName Function existing within saveRoomName on channel-settings package
deleteOutgoingIntegration
deleteIncomingIntegration
Route POST integrations.remove
updateOutgoingIntegration
updateIncomingIntegration
Route PUT integrations.update
addIncomingIntegration Route POST integrations.create
executeTriggerUrl Function executeTriggerUrl on RocketChatIntegrationHandler file

Steps to test or reproduce

  1. Start RocketChat's application with the DISABLE_DB_WATCHERS flag set to true.
  2. Perform a POST request to above given endpoints available on updated use cases.

Further comments

To maintain consistency and avoid potential regressions, event names and signatures have been kept unchanged on both the client and app sides. This decision streamlines efforts and mitigates the risk of unintended consequences.

Integration model WBS. Used to guide changes discovery.
🔄 Work in progress
✅ Done
➖ Not applicable

Function Status
findOneByUrl
updateRoomName
findOneByIdAndCreatedByIfExists
disableByUserId

Copy link
Contributor

dionisio-bot bot commented May 7, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: d32eb9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 55.55%. Comparing base (190d1de) to head (d32eb9a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32378      +/-   ##
===========================================
- Coverage    55.59%   55.55%   -0.04%     
===========================================
  Files         2408     2405       -3     
  Lines        52997    52982      -15     
  Branches     10894    10893       -1     
===========================================
- Hits         29465    29436      -29     
- Misses       20918    20943      +25     
+ Partials      2614     2603      -11     
Flag Coverage Δ
e2e 54.99% <ø> (-0.07%) ⬇️
unit 72.97% <3.84%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim force-pushed the refactor/integrations-service-out-of-db-watcher branch from 747a811 to 0976c47 Compare May 13, 2024 03:08
@ricardogarim ricardogarim changed the title refactor: integration entity out of db watcher refactor: Integration entity out of db watcher May 13, 2024
@ricardogarim ricardogarim marked this pull request as ready for review May 13, 2024 12:25
@ricardogarim ricardogarim requested review from a team as code owners May 13, 2024 12:25
@ricardogarim ricardogarim force-pushed the refactor/integrations-service-out-of-db-watcher branch from 1dd8472 to 1c53d12 Compare May 14, 2024 11:48
@ricardogarim ricardogarim force-pushed the refactor/integrations-service-out-of-db-watcher branch from 1c53d12 to f4d1e77 Compare May 14, 2024 16:46
@sampaiodiego sampaiodiego added this to the 6.9 milestone May 14, 2024
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label May 14, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 14, 2024
@kodiakhq kodiakhq bot merged commit 1c8ee73 into develop May 14, 2024
46 of 50 checks passed
@kodiakhq kodiakhq bot deleted the refactor/integrations-service-out-of-db-watcher branch May 14, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants