Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rooms.export endpoint generates an empty export when given an invalid date #32364

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented May 2, 2024

Proposed changes (including videos or screenshots)

  • Use oldest possible date as dateFrom when this param is not provided to the rooms.export endpoint;
  • Use current date as dateTo when this param is not provided to the rooms.export endpoint;
  • Added end-to-end tests for the export rooms as file feature.

Issue(s)

Steps to test or reproduce

Further comments

SUP-523

Cloned from #32046 (but based on develop)

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 1557989

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented May 2, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@matheusbsilva137 matheusbsilva137 added this to the 6.9 milestone May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.55%. Comparing base (2d84fe2) to head (1557989).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32364      +/-   ##
===========================================
- Coverage    55.60%   55.55%   -0.06%     
===========================================
  Files         2408     2408              
  Lines        53023    53110      +87     
  Branches     10902    10937      +35     
===========================================
+ Hits         29483    29503      +20     
- Misses       20931    20993      +62     
- Partials      2609     2614       +5     
Flag Coverage Δ
e2e 55.03% <ø> (-0.08%) ⬇️
unit 72.41% <37.50%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review May 3, 2024 13:57
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners May 3, 2024 13:57
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants