Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ROS actions #61

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

RobertoRoos
Copy link

To fix #60

Currently not nearly done, but I figured it could be useful to already show the work.

@RobertoRoos
Copy link
Author

RobertoRoos commented Dec 1, 2023

Currently I got some extra Action related C# code to generate, but it looks like this new code is not actually compiled into the interface libraries. I think I'm missing some extra include somewhere.

@Deric-W maybe you know? How and where is the generated interface code used? Thanks!

EDIT: Found it by looking at #36 - I needed to list the files in the CMake.

@RobertoRoos
Copy link
Author

I was trying to create a wrapper for the C-code action, with #36 as an example, but frankly I cannot reproduce this.

I might be able to create an action server instead using the existing implementations of services and messages in C#, like I'm doing here: https://github.com/RobotecAI/ros2cs/pull/61/files#diff-d8005b8b0c1727e0822794f32be7cacc0add2f27da8ab5958442a3008fd27ddfR58

@pijaro (or another maintainer), would you still be interested in merging something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ROS2 actions
2 participants