Skip to content

Add ros_launch_test bazel rule - #424

Merged
frneer merged 2 commits into
RobotLocomotion:mainfrom
frneer:frn/add_launch_testing
Jun 4, 2026
Merged

Add ros_launch_test bazel rule#424
frneer merged 2 commits into
RobotLocomotion:mainfrom
frneer:frn/add_launch_testing

Conversation

@frneer

@frneer frneer commented May 13, 2026

Copy link
Copy Markdown
Collaborator

This patch adds a ros_launch_test rule to support running launch_testing targets as bazel test.


This change is Reviewable

@julianadrianheine

Copy link
Copy Markdown
Collaborator

ros2_example_bazel_installed/setup/prereq-rosdep-keys.txt line 35 at r1 (raw file):

python3-pkg-resources
python3-psutil
python3-pytest

Are we using pytest?

@julianadrianheine julianadrianheine left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, and the examples will be really useful. I left only one question regarding the addition of python3-pytest dependency

@julianadrianheine made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on frneer).

@frneer

frneer commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

ros2_example_bazel_installed/setup/prereq-rosdep-keys.txt line 35 at r1 (raw file):

python3-pkg-resources
python3-psutil
python3-pytest

Are we using pytest?

It's a ROS dependency. There's a lint tool that verifies the deps of rosdep are the same as this file:

Without it this test fails: https://github.com/RobotLocomotion/drake-ros/actions/runs/25818202470/job/75853716222#step:7:2502.

Taking a look at this file is no longer used in the core bazel infra, so eventually we can remove it, I'll create a follow up to remove that.

@frneer frneer left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frneer made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on julianadrianheine).


ros2_example_bazel_installed/setup/prereq-rosdep-keys.txt line 35 at r1 (raw file):

Previously, frneer (Francisco Rossi) wrote…

It's a ROS dependency. There's a lint tool that verifies the deps of rosdep are the same as this file:

Without it this test fails: https://github.com/RobotLocomotion/drake-ros/actions/runs/25818202470/job/75853716222#step:7:2502.

Taking a look at this file is no longer used in the core bazel infra, so eventually we can remove it, I'll create a follow up to remove that.

#426

@julianadrianheine julianadrianheine left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@julianadrianheine made 2 comments and resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.


ros2_example_bazel_installed/setup/prereq-rosdep-keys.txt line 35 at r1 (raw file):

Previously, frneer (Francisco Rossi) wrote…

#426

I see, thanks for the explanation!

@frneer frneer left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@julianadrianheine

@frneer made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on julianadrianheine).

@julianadrianheine julianadrianheine left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@julianadrianheine made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.

@julianadrianheine julianadrianheine left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianadrianheine reviewed 6 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on frneer).

@frneer
frneer merged commit 5bd4e5e into RobotLocomotion:main Jun 4, 2026
6 checks passed
@frneer
frneer deleted the frn/add_launch_testing branch June 4, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants