Add ros_launch_test bazel rule - #424
Conversation
|
Are we using pytest? |
julianadrianheine
left a comment
There was a problem hiding this comment.
Great job, and the examples will be really useful. I left only one question regarding the addition of python3-pytest dependency
@julianadrianheine made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on frneer).
It's a ROS dependency. There's a lint tool that verifies the deps of rosdep are the same as this file: Without it this test fails: https://github.com/RobotLocomotion/drake-ros/actions/runs/25818202470/job/75853716222#step:7:2502. Taking a look at this file is no longer used in the core bazel infra, so eventually we can remove it, I'll create a follow up to remove that. |
frneer
left a comment
There was a problem hiding this comment.
@frneer made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on julianadrianheine).
ros2_example_bazel_installed/setup/prereq-rosdep-keys.txt line 35 at r1 (raw file):
Previously, frneer (Francisco Rossi) wrote…
It's a ROS dependency. There's a lint tool that verifies the deps of rosdep are the same as this file:
Without it this test fails: https://github.com/RobotLocomotion/drake-ros/actions/runs/25818202470/job/75853716222#step:7:2502.
Taking a look at this file is no longer used in the core bazel infra, so eventually we can remove it, I'll create a follow up to remove that.
julianadrianheine
left a comment
There was a problem hiding this comment.
@julianadrianheine made 2 comments and resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.
ros2_example_bazel_installed/setup/prereq-rosdep-keys.txt line 35 at r1 (raw file):
Previously, frneer (Francisco Rossi) wrote…
I see, thanks for the explanation!
frneer
left a comment
There was a problem hiding this comment.
@frneer made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on julianadrianheine).
julianadrianheine
left a comment
There was a problem hiding this comment.
@julianadrianheine made 1 comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.
julianadrianheine
left a comment
There was a problem hiding this comment.
@julianadrianheine reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on frneer).
This patch adds a
ros_launch_testrule to support runninglaunch_testingtargets asbazel test.This change is