Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): don't truncate datetime field precision #805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Oblynx
Copy link

@Oblynx Oblynx commented Aug 21, 2023

closes #804

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

Change Summary

Please summarise the changes this pull request is making here.

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

closes RobertCraigie#804

- [ ] Unit tests for the changes exist
- [ ] Tests pass without significant drop in coverage
- [ ] Documentation reflects changes where applicable
- [ ] Test snapshots have been
[updated](https://prisma-client-py.readthedocs.io/en/latest/contributing/contributing/#snapshot-tests)
if applicable

By submitting this pull request, I confirm that you can use, modify,
copy and redistribute this contribution, under the terms of your choice.
@Oblynx
Copy link
Author

Oblynx commented Aug 22, 2023

@RobertCraigie do you need anything more from me here?

@RobertCraigie
Copy link
Owner

It would be great to have a test for this case, here's a link to the docs on how to write tests - let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime microsecond precision dropped by query builder
2 participants