Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test When_type_is_in_NuGet_then_xml_docs_should_be_found and tests in Namotion.Reflection.Cecil.Tests (Linux) #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Apollo3zehn
Copy link

@Apollo3zehn Apollo3zehn commented Jan 22, 2025

Related to #33.

With the change suggested in comment #33 (comment) I am able to make the previously failing NuGet test succeed on Linux (When_type_is_in_NuGet_then_xml_docs_should_be_found).

grafik

grafik

Tests in Namotion.Reflection.Cecil.Tests are also now executed successfully:

grafik

@Apollo3zehn
Copy link
Author

I added another commit to also find the XML docs when using the artifacts output layout.

I also had to slightly modify the regex which tries to extract nuget package paths from the project.nuget.cache file. My file has the following line:

"/home/vincent/.nuget/packages/nexus.sources.structuredfile/2.0.0-beta.38/nexus.sources.structuredfile.2.0.0-beta.38.nupkg.sha512"

This is incompatible with the previously used string interpolation value assemblyName.Version.ToString(3). I replaced that one by .*?, i.e. a non-greedy match-all. This works because there will never be two versions of the same package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant