Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate redirect URL for token response type #33

Closed
wants to merge 1 commit into from
Closed

Validate redirect URL for token response type #33

wants to merge 1 commit into from

Conversation

PumpkinSeed
Copy link

Fix for #31 issue

@RichardKnop
Copy link
Owner

@PumpkinSeed Build failed for some reason :o

@PumpkinSeed
Copy link
Author

@RichardKnop I will check it on the weekend. Possible I made a mistake.

@RichardKnop
Copy link
Owner

Debug log from Travis:

122.71s$ make test
bash -c 'go list ./... | grep -v vendor | xargs -n1 go test -timeout=30s'
# github.com/RichardKnop/go-oauth2-server/oauth
oauth/client.go:72: undefined: Client
oauth/service_interface.go:35: undefined: Client
# github.com/RichardKnop/go-oauth2-server/oauth
oauth/client.go:72: undefined: Client
oauth/service_interface.go:35: undefined: Client
ok  	github.com/RichardKnop/go-oauth2-server/config	0.006s
ok  	github.com/RichardKnop/go-oauth2-server/database	0.008s
?   	github.com/RichardKnop/go-oauth2-server/health	[no test files]
?   	github.com/RichardKnop/go-oauth2-server/logger	[no test files]
ok  	github.com/RichardKnop/go-oauth2-server/models	0.006s
# github.com/RichardKnop/go-oauth2-server/oauth
oauth/client.go:72: undefined: Client
oauth/service_interface.go:35: undefined: Client
FAIL	github.com/RichardKnop/go-oauth2-server/oauth [build failed]
# github.com/RichardKnop/go-oauth2-server/oauth
oauth/client.go:72: undefined: Client
oauth/service_interface.go:35: undefined: Client
ok  	github.com/RichardKnop/go-oauth2-server/oauth/roles	0.004s
?   	github.com/RichardKnop/go-oauth2-server/oauth/tokentypes	[no test files]
ok  	github.com/RichardKnop/go-oauth2-server/session	0.006s [no tests to run]
ok  	github.com/RichardKnop/go-oauth2-server/test-util	0.874s
ok  	github.com/RichardKnop/go-oauth2-server/util	0.004s
?   	github.com/RichardKnop/go-oauth2-server/util/migrations	[no test files]
ok  	github.com/RichardKnop/go-oauth2-server/util/password	0.162s
ok  	github.com/RichardKnop/go-oauth2-server/util/response	0.004s
ok  	github.com/RichardKnop/go-oauth2-server/util/routes	0.004s
# github.com/RichardKnop/go-oauth2-server/oauth
oauth/client.go:72: undefined: Client
oauth/service_interface.go:35: undefined: Client
make: *** [test] Error 123

@RichardKnop
Copy link
Owner

@PumpkinSeed OK this seems to be related to refactoring of models I did a while ago.

I have moved all models to models package so now you would use models.OauthClient instead of Client in the oauth package.

@RichardKnop RichardKnop closed this Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants