Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Rex::TaskList. No functional change. #849

Closed
wants to merge 1 commit into from

Conversation

kablamo
Copy link
Contributor

@kablamo kablamo commented Dec 3, 2015

I'm trying to clean up the code to make way for new functionality. This pr is purely a refactor and there should be no functional changes introduced. Summary of the changes:

  • Moved $forked_sub out of Rex::TaskList->run() and into its own function.
  • This function is now shared between Rex::TaskList::Base and Rex::TaskList::Parallel_ForkManager.
  • Removed functions from Rex::TaskList::Parallel_Forkmanager which are already in Rex::TaskList::Base.

@kablamo
Copy link
Contributor Author

kablamo commented Dec 4, 2015

Ready for review

@ferki ferki added this to the 1.4.0 milestone Dec 9, 2015
@ferki
Copy link
Member

ferki commented Dec 9, 2015

It's a dependency of #851/#855.

@krimdomu
Copy link
Contributor

Hi @kablamo ,

this is now merged into master.

@krimdomu krimdomu closed this Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants