Add initial rsync tests #1357
Merged
Add initial rsync tests #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferki
force-pushed
the
rsync_test
branch
3 times, most recently
from
54f8086 to
cb6db56
Compare
ferki
force-pushed
the
rsync_test
branch
3 times, most recently
from
6b872ea to
db83c1e
Compare
|
Since a big chunk of code was indented due to moving it into one branch of a condition, this PR is best viewed with the whitespace-only changes suppressed by adding |
|
Cool. Thanks for giving Rsync some sweet, sweet love. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix #1354 by adding some initial rsync tests. For that, it also needs to introduce capability to handle local rsync operations.
Later, the test suite could be extended with additional checks, like testing behavior with wildcards or spaces in the path, and perhaps even sudo to some extent (I guess on Travis CI at least).
Checklist