Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff corpse chunks #5095

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Buff corpse chunks #5095

wants to merge 5 commits into from

Conversation

CI09
Copy link
Contributor

@CI09 CI09 commented May 3, 2024

Brief Description of What This PR Does

Buffs compounds from corpse chunks.

For testers:

  • you can check if marine snow (randomly encountered cell chunks) are worth searching for
  • you can check if killing cells (other than engulfing) doesn't grant too much compounds than it should
  • you can check if sticking to and absorbing compounds that are passively vented out of either of above don't grant too much or too least compounds

  • you can check if they do not despawn too quickly

Related Issues

Scavenging and combat balancing (it doesn't fully complete them but helps) item on roadmap

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@CI09 CI09 added the review label May 3, 2024
@CI09 CI09 added this to the Release 0.6.6.1 milestone May 3, 2024
@CI09 CI09 requested review from a team May 3, 2024 10:46
@HexapodPhilosopher
Copy link
Contributor

The marine snow is now definitely worth chasing down to engulf. You get a lot less from the cloud it creates, though.

I seem to always be able to get the same from killing a cell and then engulfing the chunks as from engulfing the whole cell. The chunks still seem to vent very little, though.

The small iron chunk is much more worth while to engulf, now. I feel it should probably be made to count as more Ingested matter, but that's probably a different issue.

Maybe the VentAmount should be 0.3f ?

@hhyyrylainen
Copy link
Member

hhyyrylainen commented May 6, 2024

I think one important parameter that is not tweaked is how much of a compound is actually preserved when spawned as a cloud (this was originally added to prevent infinite cycles of expelling and ingesting a compound at the same location). I think buffing that is going to be important to get this balanced so that cell wall gameplay balance is not destroyed.

@CI09
Copy link
Contributor Author

CI09 commented May 6, 2024

Isn't this managed by VentAmount?

@hhyyrylainen
Copy link
Member

No, I'm talking about Constants.CHUNK_VENT_COMPOUND_MULTIPLIER

@CI09
Copy link
Contributor Author

CI09 commented May 7, 2024

It might be too strong now (especially marine snow) but I'm open for opinion.

@buckly90
Copy link
Member

This is a great start!

Marine snow chunks are wildly satiating now. I recommend lowering their compound amount by a significant degree. Probably by 75%. (This would make the initial compounds 12-13 for nutrients, and 25 for glucose).
Other than that, I think this is a good step in the right direction.

I think that we could make due with a few changes to how corpse chunks retain their compounds, such as ensuring they always contain some minimum amount of glucose before they dissolve as often times they can be severely lacking in energy value despite their abundance of nutrients (phosphate, ammonia). But I would like to discuss that with the team before we commit to it so I would consider that an optional change for this PR.

@CI09
Copy link
Contributor Author

CI09 commented May 13, 2024

Thanks for review. I might try to rebalance marine snow, though it is quite bonded with other chunk emission (including corpse chunks)

@hhyyrylainen
Copy link
Member

Does this make marine snow too overpowered, then? If so then I think some further tweaking would be warranted before merging.

@CI09
Copy link
Contributor Author

CI09 commented May 15, 2024

AI Microbes seem to ignore marine snow which makes competition over them almost non-existant, so...
Anyways, reduced some value so it might change something.

@buckly90
Copy link
Member

Works great! Thank you for your work.

@hhyyrylainen
Copy link
Member

This buffs the compound amounts in corpse chunks by 10x, but if it is better game balance I guess I can accept that and I'll merge this on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants