Increase targetSdkVersion to 36 #2446
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot TestSome snapshots failed to render
🛸 Powered by Emerge Tools |
tonidero
commented
Jun 16, 2025
| import androidx.compose.material3.Button | ||
| import androidx.compose.material3.ButtonDefaults | ||
| import androidx.compose.material3.ExperimentalMaterial3Api |
There was a problem hiding this comment.
I changed TopAppBar to the material 3 import, since that already handles insets, but unfortunately it's an experimental API 🥴. I think it's fine to opt-in for now since this is a test app.
| window.statusBarColor = colorScheme.primary.toArgb() | ||
| WindowCompat.getInsetsController(window, view).isAppearanceLightStatusBars = darkTheme | ||
| } | ||
| } |
There was a problem hiding this comment.
All this is not needed anymore as far as I could tell and was causing some bad coloring for the status bar. It's not part of new project's wizard either.
|
On hold because robolectric doesn't yet support API 36: robolectric/robolectric#10103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This increases the target and compile Sdk versions of our SDKs and apps to android 16 (36). https://developer.android.com/about/versions/16/behavior-changes-16