Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate latesthasheslinked.php to filament #2462

Merged

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented May 22, 2024

Migrates latesthasheslinked.php to Filament (in order to begin building out the Game Hash resource there).

Right now, these table rows are view-only to simply recreate the functionality of the existing page. Edit/view panels can come later.

I made no effort to stylize the ~Tag~ or [Subset - Tag] elements in game titles - ideally these magic strings shouldn't live within game title strings themselves anyway and we probably shouldn't propagate the practice over to Filament.

Before
Screenshot 2024-05-22 at 6 49 18 PM

After
Screenshot 2024-05-22 at 6 52 35 PM

@wescopeland wescopeland requested a review from a team May 22, 2024 22:55
@wescopeland wescopeland merged commit 5c2c042 into RetroAchievements:master Jun 7, 2024
5 checks passed
@wescopeland wescopeland deleted the filament-latestlinkedhashes branch June 7, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants