fix(StaticData): use correct count of total games #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
May 29, 2024
Jamiras
reviewed
Jun 6, 2024
| @@ -47,11 +48,13 @@ class EventServiceProvider extends ServiceProvider | |||
| AchievementPublished::class => [ | |||
| DispatchUpdateGameMetricsJob::class, // dispatches GameMetricsUpdated | |||
| DispatchUpdateDeveloperContributionYieldJob::class, // dispatches UpdateDeveloperContributionYield | |||
| UpdateTotalGamesCount::class, | |||
There was a problem hiding this comment.
Eventually I see this also updating TotalAchievementsCount. Should that logic just be rolled into this class and renamed?
There was a problem hiding this comment.
Good point -- personally I could go either way on this (having two separate actions vs a single action).
I lean more towards having two separate actions just because the queries to construct the two data points are likely quite different, but that's a very very loosely-held opinion.
Jamiras
approved these changes
Jun 7, 2024
Oh man, I can finally do my milestone announcements without having to explain the wrong stats every time 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
static_addnewgame()in favor of a scheduled command which updatesNumGamesto the correct value on a periodic basis.Resolves #1356.