Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename UpdatePlayerStats stuff to UpdateBeatenGamesPlayerStats #2446

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented May 18, 2024

This is a precursor to another piece of work I'm tackling. Hopefully this takes some of the noise out of that PR (which will be branched off this PR's branch).

player_stats can be used to hold all kinds of stats. Right now the job/action/command naming is a bit too generic. The current set of classes is geared entirely towards stats for the beaten games leaderboard. This PR renames all that stuff to be more specific to its domain.

@wescopeland wescopeland requested a review from a team May 18, 2024 23:51
@wescopeland wescopeland merged commit 95612bf into RetroAchievements:master May 29, 2024
5 checks passed
@wescopeland wescopeland deleted the rename-beaten-game-stats-stuff branch May 29, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants