-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Games" count used on the home page is inaccurate #1356
Comments
Not directly related to accuracy, but: game counter takes subsets into account, right? Is this worth of being disclosed in the statistics grid? Or maybe changing the way data is fetched so it counts only base games? |
Disclaimer: I have not studied the My opinion is the "Games" stat should not include subsets or bonus sets. Based on the delta between games & sets, it may be worth having a "Sets" stat in the section. |
I see a It seems this is basically memoized data, right? I don't know the origin of this thing so this is coming from a place of ignorance, but is a query for these numbers that expensive? I don't know the whole database structure yet but it mostly looks like a bunch of I'm just thinking about how often this table is updated: whenever a game is added or mastered or beaten, whenever an achievement is created or unlocked, and whenever a new user signs up. So around 52 million times thus far? I don't know how many times users have hit the front page in comparison, or how that would scale, so I can't make an informed decision here. I'd love to grab this one, just unsure which direction we should move in! |
@luchaos may have a better answer. My gut feeling says anything too expensive here could probably just live in Redis. |
Describe the bug
The stats drawn from
StaticData
on the home page are not accurate.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The statistics numbers for games, achievements, etc should be precise and accurate.
Screenshot
Additional context
This emerged from this PR #1354. I have been using the site for years and did not realize these numbers were not 100% precise. I assume it is not widely known.
The text was updated successfully, but these errors were encountered: