Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 #218

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Release 0.6.0 #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c81f871
Update xtra-macros cargo.toml
Restioson Feb 2, 2024
229bef7
Use xtra-macros from crates.io
Restioson Feb 2, 2024
f538aa1
Fix readme file
Restioson Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
[package]
name = "xtra-macros"
version = "0.1.0"
version = "0.6.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to track the version of the root crate?

Copy link
Owner Author

@Restioson Restioson Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably it does not, but I think this is a standard set in other crates - serde and serde_derive seem pegged, as do bevy and bevy_internal/bevy_dylib (and even bevy_input, which is not a dependency of bevy but a core extension crate). askama and askama_derive track eachother in the minor and major version. I would argue it's a bit simpler if we don't have, say xtra 0.8 depending on 0.2 of xtra_macros. At the very least, since we re-export xtra_macros from xtra, any breaking change (while in 0.x) requires bumping xtra alongside xtra_macros. Vice versa is not strictly true but is more likely as the API surface is so small now.

Apologies for doing this without consulting you. I did it without thinking too deeply about it at the time as I'd thought this was just kind of the standard practice. I'll make sure it doesn't happen again

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does makes things easier while we are in 0.x land and after 1.x, the difference doesn't matter too much :)

edition = "2021"
license = "MPL-2.0"
repository = "https://github.com/Restioson/xtra"
description = "Helper macros for the xtra crate"
documentation = "https://docs.rs/xtra-macros"

[lib]
proc-macro = true
Expand Down
4 changes: 2 additions & 2 deletions xtra/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition = "2021"
license = "MPL-2.0"
repository = "https://github.com/Restioson/xtra"
documentation = "https://docs.rs/xtra"
readme = "README.md"
readme = "../README.md"
keywords = ["async", "actor", "futures", "xtra", "async-await"]
categories = ["asynchronous", "concurrency"]
rust-version = "1.75.0"
Expand All @@ -30,7 +30,7 @@ wasm-bindgen-futures = { version = "0.4", optional = true, default-features = fa
# Feature `instrumentation`
tracing = { version = "0.1.35", optional = true, default-features = false }

macros = { package = "xtra-macros", path = "../macros", optional = true }
macros = { package = "xtra-macros", version = "0.6.0", optional = true }

[dev-dependencies]
rand = "0.8"
Expand Down
Loading