This repository was archived by the owner on Sep 29, 2023. It is now read-only.
RS-5211 asset by serial #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had an off-by-1 in exiting early when a certain number of errors where reached.
Most common error for asset import is duplicate-asset_serial because the job was/is not fully idempotent. However, it is possible that asset_serial is legitimately wrong (eg many rows with same value) so I made ignoring that error optional default-false
It is desirable to allow many errors without stopping (and rows_to_process can be used to validate the format of the first few rows of a large file instead) so I added a UI exposed control of the number of errors to allow. Default 100k, though it should probably be much lower for memory and cpu overhead