This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Dependabot json #13
Merged
Dependabot json #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gryaznov
reviewed
Jul 1, 2021
| @@ -30,6 +30,7 @@ gem 'sidekiq' | |||
| gem 'puma' | |||
|
|
|||
| # Use SCSS for stylesheets | |||
| # NOTE: dependency gem sass-rails => gem sassc => native `libsass` which may take minutes to compile | |||
There was a problem hiding this comment.
Maybe we don't need this gem either?
I cannot find any sass/scss files in the project. Rules in app/assets/stylesheets are regular .css. Third-party libs (e.g. bootstrap) live in vendor/assets and rely on their own stylesheets with their own builds.
There was a problem hiding this comment.
we do have *.scss files in this project
I'm not inclined to spend time to test removing sass-rails until we experience a practical problem with it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address https://github.com/RepairShopr/importr/security/dependabot/Gemfile.lock/json/open CVE-202-10663 by removing
sdocand therforejsonalso remove unused
jbuilderand try to find asasscthat does not take minutes to compile