Feature/answer explainability #96
Conversation
…s, first steps in highlighting
…ntermediate result)
.gitignore
Outdated
| @@ -13,3 +13,7 @@ dummy-package/ | |||
| .vscode/ | |||
|
|
|||
| examples/llama-index/frontend/rag-ui/ | |||
|
|
|||
| pdfs/ | |||
There was a problem hiding this comment.
is the global gitignore the right place for this or is there one closer to the pdfs folder? make clear which pdf fodler is ignored here
| @@ -199,6 +199,7 @@ const ChatWindow: React.FC<ChatWindowProps> = ({ | |||
| markdown={markdown} | |||
| showCopy={showCopy} | |||
| showFeedback={showFeedback} | |||
| ideas={msg.ideas || []} | |||
There was a problem hiding this comment.
as citation mechanism is more generic consider more generic name for ideas. maybe simply chunks?
| @@ -214,6 +215,7 @@ const ChatWindow: React.FC<ChatWindowProps> = ({ | |||
| icon={assistantIcon || undefined} | |||
| markdown={markdown} | |||
| isStreaming={true} | |||
| ideas={currentStream.ideas || []} | |||
There was a problem hiding this comment.
does current stream have the idea prop? verify ans also rename prop to chunks or so
| @@ -8,6 +8,8 @@ import "./AssistantMarkdownContent.css"; | |||
| import {ClipboardIcon, ClipboardDocumentIcon} from "@heroicons/react/24/outline"; | |||
| import {scaleFontSize} from "../../utils/scaleFontSize.tsx"; | |||
| import { MessageFeedback } from "./MessageFeedback.tsx"; | |||
| import { HighlightedIdea } from '../../types'; | |||
There was a problem hiding this comment.
rename that type to something more generic as well
| @@ -27,7 +29,7 @@ interface AssistantMarkdownContentProps { | |||
| * | |||
| * @internal | |||
| */ | |||
| const AssistantMarkdownContent: React.FC<AssistantMarkdownContentProps> = ({content, style}) => { | |||
| export const AssistantMarkdownContent: React.FC<AssistantMarkdownContentProps> = ({content, style}) => { | |||
There was a problem hiding this comment.
why is export added? valid reason, else remove
lexio/package.json
Outdated
| "dompurify": "^3.2.4", | ||
| "esbuild": "^0.24.2", |
There was a problem hiding this comment.
where does esbuild come from here? is already installed i guess in dev deps
lexio/src/sbd.d.ts
Outdated
| @@ -0,0 +1,2 @@ | |||
| declare module 'sbd' | |||
| ], | ||
| build: { | ||
| copyPublicDir: false, | ||
| outDir: 'dist', |
There was a problem hiding this comment.
comment what you changed here
package-lock.json
Outdated
package.json
Outdated
No description provided.