WIP: Excel viewer #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lexio/lib/components/ContentDisplay/ContentDisplay.tsx # lexio/lib/types.ts # lexio/package-lock.json # lexio/package.json
SYoy
reviewed
Mar 11, 2025
| @@ -165,6 +166,12 @@ export interface Source { | |||
| * These highlights will be visually displayed in the PDF viewer. | |||
| */ | |||
| highlights?: PDFHighlight[]; | |||
There was a problem hiding this comment.
only use one highlights prop, make it a union of PDF and SpreedsheetHighlight
| }; | ||
| export interface PDFHighlight { |
| /** | ||
| * The name of the sheet where the highlight appears. | ||
| */ | ||
| sheetName: string; |
There was a problem hiding this comment.
can you make it work wqith sheetName optional? what is the default case in the viewer?
| @@ -69,44 +72,82 @@ const ContentDisplay: React.FC<ContentDisplayProps> = ({ | |||
| ...removeUndefined(styleOverrides), | |||
| }; | |||
|
|
|||
| const source = selectedSourceId ? (sources.find((s) => s.id === selectedSourceId) ?? undefined) : undefined; | |||
There was a problem hiding this comment.
use the selectedSource directly? no need to look it up in sources
| @@ -0,0 +1,5 @@ | |||
| import { clsx, type ClassValue } from "clsx" | |||
| type Props = { | ||
| fileName?: string | undefined; | ||
| fileBufferArray: ArrayBuffer; | ||
| defaultSelectedSheet?: string | undefined; |
There was a problem hiding this comment.
can you use our current schema for component props definition with extensive jsdocs. see ChatWindow component https://github.com/Renumics/lexio/blob/main/lexio/lib/components/ChatWindow/ChatWindow.tsx
|
I tested out the viewer with another excel file than the on provided by you and got some issues. lets discuss it in person later today :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.