-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove uppercase styles #2160
fix: remove uppercase styles #2160
Conversation
🦋 Changeset detectedLatest commit: 83748d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: -27 B (-0.01%) Total Size: 207 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a changeset for the changes to tile, stat, and health index
@ArathyKumar, there are additional css adjustments to some of the text that used to be in uppercase. Would you want to make those changes in this PR or in a separate one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can this be merged into
staging/cubone
instead ofmain
? It'll help us work on some docs updates and additional text style updates.
Hey @marionnegp, Thank you so much for your thorough review. I’ve made all the changes as per your suggestions. Could you please review it again. |
@marionnegp we can merge this into main then update the cubone branch afterwards, easy-peasy |
Will this end up getting added to #2046? |
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ArathyKumar!
What I did
Removed all the CSS that forces headings to be in all caps.