-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(navigation-secondary): update best practices and guidelines #2157
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +2 B (0%) Total Size: 207 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marionnegp Couple edits.
- First image under
Number of slots
heading is very small - Second image is broken for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about the use of "Slot 1", "Slot 2", and "Slot 3" - the word "slot" has a very specific, technical meaning in our design system. <rh-navigation-secondary>
actually has four slots, but their names are different from the ones referenced here in the docs. Instead the actual names of the slots are logo
, nav
, cta
, and mobile-menu
. Would it be better for users for us to refer to the slots by their actual names in all places?
red-hat-design-system/elements/rh-navigation-secondary/rh-navigation-secondary.ts
Lines 177 to 185 in d1182b0
<slot name="logo" id="logo"></slot> | |
<button aria-controls="container" | |
aria-expanded="${String(expanded) as 'true' | 'false'}" | |
@click="${this.#toggleMobileMenu}"><slot name="mobile-menu">Menu</slot></button> | |
<rh-surface color-palette="${dropdownPalette}"> | |
<slot name="nav"></slot> | |
<div id="cta" part="cta"> | |
<slot name="cta"></slot> | |
</div> |
@bennypowers Yes, we should change the name. @marionnegp Do you need me to update the images or do you want to? |
@coreyvickery, I can make these changes. Thanks! |
What I did
Testing Instructions
Notes to Reviewers