For #1 Add buttons to open the android developers web page #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button becomes invisible after clicking. Opens URL: https://developer.android.com/
Thw top site is gone after clicking. Opens URL: https://developer.android.com/
|
Congrats on your first PR! |
RebecaTudor
force-pushed
the
add_new_element_on_home_page
branch
from
253321f to
6baa79e
Compare
Before, the Open web page button was still visible after clicking it. Fixed by adding correctly in state the boolean value received. Names are changed for easier understanding of code: - OpenWebPageInteractor -> BottomButtonsInteractor - openAndroidDeveloperWebPage -> onOpenWebPageClicked - handleOpenAndroidDeveloperWebPageTapped -> handleOpenWebPageClicked - OpenWebPageButtonVisiblity -> VisibilityButtonChange
RebecaTudor
force-pushed
the
add_new_element_on_home_page
branch
from
6baa79e to
00cde0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device-2023-02-06-131532.mp4
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-debugtask.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Used by GitHub Actions.