Don't destroy immature netherwart with crop filter. Fixes #298 #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cocoa blocks should also be accounted for. I can't think of any other minecraft croplike blocks that aren't subclasses of CropBlock. |
|
It looks like this was closed accidentally when I reset my 1.21 branch (I forgot to "git checkout" after "git branch" when I made the new branch for this PR). I don't see any option to change the branch that this compares against. Are you able to change this to pull the jshipley/netherwart_crop_filter branch, or should I just open a new PR? |
|
I'm just going to open a new one from the correct branch... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netherwart block isn't actually a crop block (probably because bone meal doesn't work on it).
This PR changes the immature crop test for the block destroyer and enderic laser when a crop filter addon is present so that immature netherwart will not be destroyed.