Skip to content

Conversation

@Shyam-Vishwakarma
Copy link
Contributor

@Shyam-Vishwakarma Shyam-Vishwakarma commented May 15, 2025

Date: 16 May 2025

Developer Name: @Shyam-Vishwakarma


Issue Ticket Number

Description

  • Refactored the structure of the query. Removed use of text area ("""...""")
  • Deploye to EC2 is failing for dev to main sync because of the string format. Use of text area is causing formatting failure.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

@coderabbitai
Copy link

coderabbitai bot commented May 15, 2025

Summary by CodeRabbit

  • Style
    • Reformatted database query annotations for improved consistency; no impact on functionality or user experience.

Walkthrough

The changes reformat JPQL queries in two repository classes by converting multi-line triple-quoted query strings into single-line concatenated strings within the @Query annotations. No logic, method signatures, or query semantics are altered; only the formatting of the queries is updated.

Changes

File(s) Change Summary
skill-tree/src/main/java/com/RDS/skilltree/repositories/EndorsementRepository.java Reformatted the JPQL query in the @Query annotation from a multi-line text block to a single-line string.
skill-tree/src/main/java/com/RDS/skilltree/repositories/UserSkillRepository.java Reformatted all JPQL queries in @Query annotations from multi-line text blocks to single-line strings.

Poem

A hop and a skip through the code today,
Queries now trimmed in a single-line way.
No logic disturbed, just neater to see,
As rabbits prefer their code tidy as can be!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afb7a76 and 3740d3d.

📒 Files selected for processing (2)
  • skill-tree/src/main/java/com/RDS/skilltree/repositories/EndorsementRepository.java (1 hunks)
  • skill-tree/src/main/java/com/RDS/skilltree/repositories/UserSkillRepository.java (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
skill-tree/src/main/java/com/RDS/skilltree/repositories/EndorsementRepository.java (1)
Learnt from: Shyam-Vishwakarma
PR: Real-Dev-Squad/skill-tree-backend#198
File: skill-tree/src/main/java/com/RDS/skilltree/repositories/EndorsementRepository.java:14-21
Timestamp: 2025-05-08T07:55:14.257Z
Learning: In the skill-tree-backend project, the complex JOIN query in EndorsementRepository is necessary because the automatically generated JPA query (from method name) doesn't work for the required endorsement verification logic between Endorsement and UserSkills tables.
skill-tree/src/main/java/com/RDS/skilltree/repositories/UserSkillRepository.java (1)
Learnt from: Shyam-Vishwakarma
PR: Real-Dev-Squad/skill-tree-backend#198
File: skill-tree/src/main/java/com/RDS/skilltree/repositories/EndorsementRepository.java:14-21
Timestamp: 2025-05-08T07:55:14.257Z
Learning: In the skill-tree-backend project, the complex JOIN query in EndorsementRepository is necessary because the automatically generated JPA query (from method name) doesn't work for the required endorsement verification logic between Endorsement and UserSkills tables.
🔇 Additional comments (4)
skill-tree/src/main/java/com/RDS/skilltree/repositories/EndorsementRepository.java (1)

14-17: Formatting update for JPQL query
The @Query annotation has been reformatted from a multi-line text block into a single-line concatenated string. The logical conditions remain unchanged, and whitespace between segments ensures the query is valid.

skill-tree/src/main/java/com/RDS/skilltree/repositories/UserSkillRepository.java (3)

15-18: Consistent formatting for legacy endorser query
The findUserSkillsByEndorserIdLegacy JPQL query has been converted to a concatenated single-line string without altering its logic. Whitespace is preserved to maintain query validity.


21-24: Consistent formatting for endorser join query
The findUserSkillsByEndorserId query has been refactored to a single-line concatenation, matching the style of other repository queries. The join and filter semantics are identical to before.


27-32: Consistent formatting for status‐filtered endorser query
The findByStatusAndEndorserId JPQL annotation is now a single-line concatenated string. Logic for joining and filtering by status and endorser remains intact.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@iamitprakash iamitprakash merged commit 785af90 into RealDevSquad:develop May 15, 2025
4 checks passed
@Shyam-Vishwakarma Shyam-Vishwakarma deleted the formatting branch May 15, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants