Open
Conversation
namespace import is broken, and only worked because it's the same as default import in CJS code (require()).
error TS2345: Argument of type '{ default: ChaiPlugin; }' is not assignable to parameter of type 'ChaiPlugin'.
Type '{ default: ChaiPlugin; }' provides no match for the signature '(chai: ChaiStatic, utils: ChaiUtils): void'.
exports the function so a commonjs script can require() it directly.
dynst
force-pushed
the
tsconfig-update
branch
from
3e2e326 to
a8ce22f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update
@types/nodeand add some recommended options to tsconfig, including turning onnoImplicitOverride, and following changes in upstream Angular defaults angular/angular-cli#27988Also fix this compile error that shows up with newer
tscversions:BREAKING CHANGE:
Related issue (if exists):