-
Notifications
You must be signed in to change notification settings - Fork 62
docs(operators): add documentation for of #265
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 115 115
Lines 442 442
Branches 10 10
=======================================
Hits 400 400
Misses 40 40
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few suggestions 👍
src/operator-docs/creation/of.ts
Outdated
// ... | ||
externalLink: { | ||
platform: 'JSBin', | ||
url: 'http://jsbin.com/porolatazu/embed?js,output' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want console, not output in the embed http://jsbin.com/porolatazu/embed?js,console
when those notifications will be delivered.</p> | ||
` | ||
}, | ||
examples: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things:
- It looks like you have conflicting variables with
interval
- I believe you can combine the two
concat
's
With update it would look something like:
const numbers = of(10, 20, 30);
const letters = of('a', 'b', 'c');
const interval$ = interval(1000);
const result = numbers.pipe(concat(letters, interval$));
result.subscribe(x => console.log(x));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the feedback. Changes are pushed!
closes #81