Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

docs(operators): add documentation for of #265

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

niklas-wortmann
Copy link
Member

closes #81

@codecov-io
Copy link

codecov-io commented Feb 13, 2018

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2
Impacted Files Coverage Δ
src/operator-docs/creation/of.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22df95...09e67c4. Read the comment docs.

Copy link
Collaborator

@btroncone btroncone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions 👍

// ...
externalLink: {
platform: 'JSBin',
url: 'http://jsbin.com/porolatazu/embed?js,output'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want console, not output in the embed http://jsbin.com/porolatazu/embed?js,console

when those notifications will be delivered.</p>
`
},
examples: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things:

  1. It looks like you have conflicting variables with interval
  2. I believe you can combine the two concat's

With update it would look something like:

const numbers = of(10, 20, 30);
const letters = of('a', 'b', 'c');
const interval$ = interval(1000);
const result = numbers.pipe(concat(letters, interval$));
result.subscribe(x => console.log(x));

StackBlitz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback. Changes are pushed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for operator : creation - of
5 participants