feat(rxdart_flutter): add ValueStream widgets #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three new Flutter widgets for working with ValueStreams: - `ValueStreamBuilder`: A widget that rebuilds UI based on `ValueStream` updates - `ValueStreamListener`: A widget that performs side effects when `ValueStream` values change - `ValueStreamConsumer`: A widget combining both builder and listener capabilities for `ValueStream`s Features: - Optimized for ValueStreams with required initial values - Proper error handling for streams without values/with errors - Optional buildWhen condition for controlling rebuilds - Access to previous/current values in listeners - 100% test coverage - Detailed documentation and examples
|
Thank you for your PR, I will take a look at it ASAP. |
hoc081098
reviewed
Jan 29, 2025
Enhance error handling in `validateValueStreamInitialValue` by: - Preserving the original stream's stack trace when available - Falling back to `StackTrace.current` only when no stack trace is present
…dencies - Remove local import of rxdart_flutter.dart - Add direct import of rxdart package - Import ValueStreamListener - Streamline import statements for better modularity
…handling Improve the initial value handling in ValueStreamListener by: - Dynamically adjusting skip count based on initialization state - Removing post-frame callback for initial value notification
- Remove null assertion from currentValue in ValueStreamBuilder and ValueStreamConsumer - Add test cases for nullable types - Improve test variable naming for better readability
…gets - Update ValueStreamBuilder, ValueStreamConsumer, and related tests to support an optional `child` parameter - Modify builder signatures to include child widget - Add documentation explaining the purpose and usage of the child parameter - Enhance example code to demonstrate stable child widget usage - Replace BehaviorSubject with ValueStream in tests apps
- Introduce `isReplayValueStream` parameter to ValueStream widgets - Update ValueStreamBuilder, ValueStreamConsumer, and ValueStreamListener to handle non-replay streams - Add comprehensive test cases for non-replay stream scenarios - Modify listener and builder behaviors based on stream replay configuration - Update debug properties to include `isReplayValueStream`
|
It looks good to me 🙏 Could you please update the flutter_search sample as well? It seems that the builder signature has been changed (with the addition of child param). |
hoc081098
reviewed
Jan 31, 2025
…nclude child parameter
…ner issues Updated package dependencies via flutter pub upgrade to fix build_runner execution failures.
- Add network client entitlements for debug and release configurations - Update AppDelegate with @main annotation and secure restorable state method - Upgrade Xcode project to version 1510 - Add RunnerTests target with a basic test case - Simplify FlutterViewController initialization
Improve stream skipping logic in ValueStreamListener by: - Conditionally applying skip only when skipCount is greater than 0 - Simplify stream listening mechanism
I did it and added support for macOS. It had some issues when running it. |
hoc081098
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add three new Flutter widgets for working with ValueStreams:
ValueStreamBuilder: A widget that rebuilds UI based onValueStreamupdatesValueStreamListener: A widget that performs side effects whenValueStreamvalues changeValueStreamConsumer: A widget combining both builder and listener capabilities forValueStreamsFeatures:
Closes #779