[do not yet merge] Refactor EventSource #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #28, I noticed that there's quite some code duplication in this project which could be eliminated.
My solution is to factor out the common code into an abstract class
EventSource
, and intoSwingObservable.create
.You will observe that some of my new
XxxEventSource
classes implement theaddListenerForComponent
/removeListenerFromComponent
methods, while others don't. The reason for this irregularity is that there are two kinds of Swing events:addXxxListener
andremoveXxxListener
method. Examples: All Swing classes supportingKeyEvent
inherit fromComponent
, and all Swing classes supportingItemEvent
implementItemSelectable
.ActionEvent
,ChangeEvent
.My solution works for both of them, and is only slightly more verbose for the tricky ones.
Consider this PR as a preview. I've only performed the refactoring for a few event sources, and before we do it for all of them, I'd like to know what others think of it.