Add default combining behavior to combine_latest operator #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no block is specified, the
combine_latest
operator should combine its two streams into an array (a pair of elements).Currently,
combine_latest
errors when no block is specified:In the RxJS implementation, elements from both streams are combined into an array by default:
In RxRuby, this is also the behavior with the static version of
combine_latest
, i.e.Rx::Observable.combine_latest(lo, ro).subscribe { |x| pp x }
works as expected (see implementation here)This patch updates the instance version of
combine_latest
to match the static version and makeslo.combine_latest(ro).subscribe { |x| pp x }
work as expected by combining the elements into an array.