Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javadoc on ActionDisposable, correction of dangling javadoc comme… #6728

Closed
wants to merge 1 commit into from

Conversation

c-nasser
Copy link

@c-nasser c-nasser commented Nov 27, 2019

Javadoc corrections :

  • add javadoc on ActionDisposable
  • correction of dangling javadoc comments
  • remove of unnecessary '@see' (on same method)

Issue #4535.

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #6728 into 3.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               3.x    #6728      +/-   ##
===========================================
- Coverage     98.1%   98.09%   -0.02%     
  Complexity    6189     6189              
===========================================
  Files          677      677              
  Lines        44663    44663              
  Branches      6171     6171              
===========================================
- Hits         43818    43812       -6     
- Misses         304      308       +4     
- Partials       541      543       +2
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 559 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 172 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 537 <0> (ø) ⬇️
...operators/flowable/BlockingFlowableMostRecent.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 148 <0> (ø) ⬇️
...eactivex/rxjava3/disposables/ActionDisposable.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ators/observable/BlockingObservableMostRecent.java 100% <ø> (ø) 2 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.88% <0%> (-5.56%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.14% <0%> (-3.13%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-1.71%) 2% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a498d...c0a91b8. Read the comment docs.

akarnokd
akarnokd previously approved these changes Nov 27, 2019
Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to re-review this in source because some links need to be updated, not deleted.

@akarnokd
Copy link
Member

Superseeded by #6729.

@akarnokd akarnokd closed this Nov 28, 2019
@c-nasser c-nasser deleted the DocClean3x branch November 29, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants