enforce C++14 in cmake + added rxcpp::is_same_v C++14 compatible definition ... #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in view of >=C++17's
std::is_same_v
see also post-PR discussion at: #572 (comment)
I tried to keep it as non-intrusive as possible and defined a
rxcpp::is_same_v
template pair inrx-trace.cpp
since this seems to be the place that most (all?) of the other includes reference. Needed thestatic constexpr bool ...
because C++14 does not allow for 'inline' and sinceis_same_v
is a value and not type trait*.@guhwanbae @kirkshoop hope and please let me know if this helps with the issue mentioned above.
P.S. *I noticed that the build times are quite large (possibly because of SFINAE, enable_ifs, etc.). Would be worthwhile to perhaps consider moving RxCpp to the current standard (C++20)?? ... more features (concepts), lots of goodies, ranges (that seem to be similar/related to RxCpp), simpler/more succinct code, and faster compile-times. Food for thought.