-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 3.9 julia
Overhaul
#2749
base: feat/py39_rebase
Are you sure you want to change the base?
Conversation
The pure-python tests fail on MacOS because between Python 3.7 and 3.9 the way multiprocessing works was changed (see https://stackoverflow.com/a/72830812) - we violate the requirements for using this new method (see https://docs.python.org/3/library/multiprocessing.html#the-spawn-and-forkserver-start-methods) so we may just need to set the method back to the old way. |
Using PythonCall with an existing conda environment: https://discourse.julialang.org/t/how-to-use-pythoncall-with-a-previous-conda-environment/87419 |
the PYTHONCALL suggestion is here: https://discourse.julialang.org/t/how-to-use-pythoncall-with-a-previous-conda-environment/87419/8 changing to current will hopefully prevent condapkg from making a new environment
Setting Now attempting to set |
Julia sees the correct environment (I think), so next is solving the error that Julia can't see the libraries. I think this may fix it: https://stackoverflow.com/a/77206459 |
|
Same error; no solution: https://discourse.julialang.org/t/fatal-python-error-when-running-julia-on-mac-m1-vs-code/109540/4 |
The PYTHONPATH environment variable is an alternative method to just installing the package, which we are doing (?) - see: https://stackoverflow.com/questions/39363544/difference-between-adding-path-to-pythonpath-and-installing-your-own-module
Another person with the same issue; no solution - https://discourse.julialang.org/t/pycall-installation-on-macos-m1/87980 |
More related: JuliaPy/PyCall.jl#410 (comment) |
…se; and... check that PYTHONHOME and PYTHONPATH are unset, both of which have a high likelihood of messing up the install process
Next debugging step is to set JULIA_PYTHONCALL_EXE to the python executable rather than setting PYTHON: https://juliapy.github.io/PythonCall.jl/stable/pythoncall/#If-you-already-have-Python-and-required-Python-packages-installed |
ARM-mac can't see |
Seems that for Ubuntu the install works, but then during tests Python can't find it's |
The RMG modules are built in place, which is why we need to set PYTHONPATH: https://stackoverflow.com/a/7851585 Maybe we also need to set the system path to point toward the libs in the conda environment? |
Intel Mac now fails only the tests that are due to the change in |
also don't set those env vars that are meessing things up i think
Current theory is that we have to set PYTHONPATH because we aren't actually installing rmgpy or arkane, just building them, so that Julia can see arkane and rmgpy during its installation process. But this then messes up the actual execution, since setting PYTHONPATH seems to mess up the normal path, making python unable to find its libs Potential fix to this potential problem is to make the code actually installable |
@jonwzheng a familiar name has popped up on this PR:
|
I have now confirmed that without installing Julia, the tests work. Something about installing |
The Python 3.9 Upgrade is complete, but the new
juliacall
setup does not work. Current theory is thatjulia
cannot 'see' the Python environment and/or its dependencies. Will address here.