Skip to content

fix: Respect device locale on launch (fallback to English) #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

fix: Respect device locale on launch (fallback to English) #2488

wants to merge 2 commits into from

Conversation

TheAabedKhan
Copy link
Member

@TheAabedKhan TheAabedKhan commented Apr 17, 2025 •
edited
Loading

If the device's language is not supported by ReVanced Manager, English language will be used.

@TheAabedKhan
Copy link
Member Author

I didn't see another PR

@TheAabedKhan TheAabedKhan reopened this Apr 17, 2025
@TheAabedKhan
Copy link
Member Author

TheAabedKhan commented Apr 17, 2025 •
edited
Loading

The #2483 adds unnecessary code

@TheAabedKhan TheAabedKhan linked an issue Apr 17, 2025 that may be closed by this pull request
bug: Language is always set to English on launch #2478
Open
4 tasks
@TheAabedKhan TheAabedKhan marked this pull request as draft April 22, 2025 07:10
@oSumAtrIX
Copy link
Member

Is this PR ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Language is always set to English on launch
2 participants
@TheAabedKhan @oSumAtrIX