allow configurable name for cni pods so we're waiting for the right ones #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghormoon
force-pushed
the
configurable-cni-name
branch
from
6c0a471
to
4d7703d
Compare
ghormoon
force-pushed
the
configurable-cni-name
branch
from
4d7703d
to
b448560
Compare
| @@ -29,6 +29,7 @@ ClusterConfiguration: | |||
| kubernetesVersion: "v{{ KUBERNETES_VERSION }}" | |||
| # dns: | |||
| networking: | |||
| cni_pod_name: "{{ POD_CNI_NAME }}" | |||
There was a problem hiding this comment.
is there such a thing in the api?
#https://pkg.go.dev/k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm/v1beta3?tab=doc#ClusterConfiguration
#check latest api ver here: https://pkg.go.dev/k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm?tab=subdirectories
There was a problem hiding this comment.
this is only used in your "grep" searches for pods. should i put it in another place in the variable stercture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows user to configure POD_CNI_NAME in variables. The reason is, if you replace calico with other CNI (eg antrea) in addons, it will wait long time for calico-node to come up. It makes more sense to be able to conifgure CNI-specific name to wait for.