vignettes: avoid using _ or . in header IDs #6784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data.table-intro on CRAN: <h3 id="h-great-but-how-can-i-refer-to-columns-by-names-in-j-like-in-a-data-frame" #refer_j>h) Great! But how can I refer to columns by names in <code>j</code> (like in a <code>data.frame</code>)?</h3> <h4 id="how-can-we-calculate-the-number-of-trips-for-each-origin-airport-for-carrier-code-quot-aa-quot" #origin-.N>– How can we calculate the number of trips for each origin airport for carrier code <code>"AA"</code>?</h4> <h4 id="how-can-we-get-the-total-number-of-trips-for-each-origin-dest-pair-for-carrier-code-quot-aa-quot" #origin-dest-.N>– How can we get the total number of trips for each <code>origin, dest</code> pair for carrier code <code>"AA"</code>?</h4> This is not valid HTML and the links to these headers don't work. "Intro" seems to be the only vignette affected.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6784 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14642 14642
=======================================
Hits 14438 14438
Misses 204 204 ☔ View full report in Codecov by Sentry. |
|
Want to have a go at writing a simple https://github.com/Rdatatable/data.table/tree/master/.ci/linters/md |
MichaelChirico
approved these changes
Jan 31, 2025
This doesn't parse the full range of Pandoc's header_attributes extension (one shouldn't be using regular expressions for that), but at least it captures the existing mistakes without obvious false positives.
|
Pardonnez-moi @Rdatatable/french, I hope you don't mind me fixing the heading ids and the links without changing the text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Introduction to data.table" on CRAN seems to be the only vignette affected:
As a result, the links to these headers don't work.