Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress deprecated option 'datatable.nomatch' to error #6644

Open
wants to merge 2 commits into
base: depr-withset
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Dec 10, 2024

This has been warning for 3 years, though the CRAN version has only been warning for 1 year, hence targeting this for 1.18.0

@MichaelChirico MichaelChirico added this to the 1.18.0 milestone Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (7f5a437) to head (cd7b5a1).

Additional details and impacted files
@@              Coverage Diff              @@
##           depr-withset    #6644   +/-   ##
=============================================
  Coverage         98.64%   98.64%           
=============================================
  Files                79       79           
  Lines             14637    14637           
=============================================
  Hits              14439    14439           
  Misses              198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Comparison Plot

Generated via commit 2545bd8

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 40 seconds
Installing different package versions 7 minutes and 31 seconds
Running and plotting the test cases 2 minutes and 14 seconds

@MichaelChirico MichaelChirico requested review from ben-schwen and removed request for ben-schwen December 30, 2024 05:31
@MichaelChirico MichaelChirico changed the base branch from master to graphite-base/6644 February 25, 2025 06:34
@MichaelChirico MichaelChirico changed the base branch from graphite-base/6644 to depr-withset February 25, 2025 06:34
Copy link
Member Author

MichaelChirico commented Feb 25, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant