Check roll-on-factor up-front to simplify later checks #6639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6603.
This introduces a tiny amount of redundancy in the check code, but I think it's worth it, especially with the next PR to follow which moves all of this into a helper.
Also added explicit argument names to between.R since there are so many/not apparent from context. I was trying to decide if the
roll=
check could just be done in[
instead; it can but the cost of possibly missing that check at another call site (even though non today exist) is not worth it given the check would need to happen just beforebmerge()
is invoked anyway, i.e., it's not like we can add this check very high in[
and avoid a lot of overhead.All of this is towards #6628.