Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check roll-on-factor up-front to simplify later checks #6639

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

Follow-up to #6603.

This introduces a tiny amount of redundancy in the check code, but I think it's worth it, especially with the next PR to follow which moves all of this into a helper.

Also added explicit argument names to between.R since there are so many/not apparent from context. I was trying to decide if the roll= check could just be done in [ instead; it can but the cost of possibly missing that check at another call site (even though non today exist) is not worth it given the check would need to happen just before bmerge() is invoked anyway, i.e., it's not like we can add this check very high in [ and avoid a lot of overhead.

All of this is towards #6628.

Copy link

github-actions bot commented Dec 7, 2024

Comparison Plot

Generated via commit 0158272

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 48 seconds
Installing different package versions 7 minutes and 29 seconds
Running and plotting the test cases 2 minutes and 16 seconds

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (96e89fa) to head (0158272).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6639   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          79       79           
  Lines       14543    14548    +5     
=======================================
+ Hits        14342    14347    +5     
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant