revert fix ViewPager2 crash to avoid TransactionTooLargeException

Razeeman · Feb 1, 2025 · 6bb7519 · 6bb7519
1 parent fd1f2c4
commit 6bb7519
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/core/src/main/java/com/example/util/simpletimetracker/core/base/BaseFragment.kt b/core/src/main/java/com/example/util/simpletimetracker/core/base/BaseFragment.kt
@@ -33,8 +33,6 @@ abstract class BaseFragment<T : ViewBinding> : Fragment(), Throttler {
         // This also somehow fixes memory leaks occurring on navigation
         // from main to some edit screen and back.
         // If this ever changes - need to also fix these memory leaks.
-        // Also ViewPagers has isSaveEnabled set to false, to avoid crash
-        // "Expected the adapter to be 'fresh' while restoring state".
         return _binding?.root?.also {
             initialized = true
         } ?: run {

diff --git a/core/src/main/java/com/example/util/simpletimetracker/core/view/SafeFragmentStateAdapter.kt b/core/src/main/java/com/example/util/simpletimetracker/core/view/SafeFragmentStateAdapter.kt
@@ -83,6 +83,11 @@ class SafeFragmentStateAdapter(
 
     override fun restoreState(savedState: Parcelable) {
         try {
+            // Restoring is crashing with "Expected the adapter to be 'fresh' while restoring state".
+            // Don't need it anyway, because binding is saved in BaseFragment.
+            // Crash can be avoided with setSaveEnabled,
+            // which would cause skipping of saveState / restoreState,
+            // but it will cause fragments to save themselves which would cause TransactionTooLargeException.
             adapter.restoreState(savedState)
         } catch (e: Exception) {
             Timber.e(e)

diff --git a/...e_main/src/main/java/com/example/util/simpletimetracker/feature_main/view/MainFragment.kt b/...e_main/src/main/java/com/example/util/simpletimetracker/feature_main/view/MainFragment.kt
@@ -79,7 +79,6 @@ class MainFragment : BaseFragment<Binding>() {
     }
 
     private fun setupPager() = with(binding) {
-        mainPager.isSaveEnabled = false // See BaseFragment.
         mainPager.adapter = SafeFragmentStateAdapter(
             MainContentAdapter(
                 fragment = this@MainFragment,

diff --git a/.../java/com/example/util/simpletimetracker/feature_records/view/RecordsContainerFragment.kt b/.../java/com/example/util/simpletimetracker/feature_records/view/RecordsContainerFragment.kt
@@ -55,7 +55,6 @@ class RecordsContainerFragment :
 
     override fun initUi(): Unit = with(binding) {
         pagerRecordsContainer.apply {
-            isSaveEnabled = false // See BaseFragment.
             adapter = SafeFragmentStateAdapter(
                 RecordsContainerAdapter(this@RecordsContainerFragment),
             )

diff --git a/...com/example/util/simpletimetracker/feature_statistics/view/StatisticsContainerFragment.kt b/...com/example/util/simpletimetracker/feature_statistics/view/StatisticsContainerFragment.kt
@@ -53,7 +53,6 @@ class StatisticsContainerFragment :
 
     override fun initUi(): Unit = with(binding) {
         pagerStatisticsContainer.apply {
-            isSaveEnabled = false // See BaseFragment.
             adapter = SafeFragmentStateAdapter(
                 StatisticsContainerAdapter(this@StatisticsContainerFragment),
             )