Fix: Update src/create_fasta.py #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 15638ff, binsplitting was refactored. This change removed the minsize keyword from vambtools.write_bins, which src/create_fasta.py relies on, breaking the script. Fix this, by making the following changes: * Read in the FASTA in two passes, one to figure out which sequences to store in memory, and one which stored them * Filter the bins in the script before calling write_bins * Change the default max bins from the overly conservative 250 to 1000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 15638ff, binsplitting was refactored. This change removed the minsize keyword from vambtools.write_bins, which src/create_fasta.py relies on, breaking the script.
Fix this, by making the following changes: