Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area#removeRoomFromMap #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ratacat
Copy link
Contributor

@ratacat ratacat commented Jul 23, 2019

Currently if you Area#addRoom() it adds the room to the floor map, but you if call Area#removeRoom, it removes it from the area, but leaves it in the floor map. Resulting in bad things, like crashes when a player tries to view adjacent rooms that lookup their implied exits through the floor map. Any suggestions on how this could better?

@shawncplus
Copy link
Member

Code looks solid, I'd really like a unit test for it though

@ratacat
Copy link
Contributor Author

ratacat commented Jul 24, 2019

I have absolutely no idea how to do that, but I'm willing to try =) Any examples I can look at?

@shawncplus
Copy link
Member

https://github.com/RanvierMUD/core/blob/master/test/unit/Attribute.js is a super simple example. I'm been really bad about adding tests so there aren't many but that's a good base to work off of, it's using mocha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants