Skip to content
This repository has been archived by the owner on Aug 10, 2024. It is now read-only.

get feed URL and use that to resolve URL if link is empty #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Sources/ObjC/RSRSSParser.m
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,15 @@ - (NSString *)urlString:(NSString *)s {
return s;
}

if (!self.link) {
//TODO: get feed URL and use that to resolve URL.*/
if (!self.link || ![self.link hasPrefix:@"http"]) {
NSURL *feedURL = [NSURL URLWithString:self.urlString];
if (!feedURL) {
return s;
}
NSURL *resolvedURL = [NSURL URLWithString:s relativeToURL:feedURL];
if (resolvedURL.absoluteString) {
return resolvedURL.absoluteString;
}
return s;
}

Expand Down
9 changes: 9 additions & 0 deletions Tests/RSParserTests/RSSParserTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,13 @@ class RSSParserTests: XCTestCase {
// XCTAssertNotNil(article.contentHTML)
// }
// }

func testFeedWithHomeEmpty() {
let d = parserData("fuli51", "html", "https://www.fuli51.net/feed")
let parsedFeed = try? FeedParser.parse(d)

for article in parsedFeed?.items ?? [] {
XCTAssertTrue(article.url?.starts(with: "https://www.fuli51.net") ?? false )
}
}
}
Loading