Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Menu: add time of compilation to timestamp build #2075

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ia
Copy link
Collaborator

@ia ia commented Feb 13, 2025

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Add time of compilation to timestamp build in Debug Menu.

  • What is the current behavior?
    Timestamp in Debug Menu shows date of build only.

  • What is the new behavior (if this is a feature change)?
    Timestamp in Debug Menu shows time of build (HHMMSS) right next to a date of build.

  • Other information:
    While testing different builds with local changes only (i.e., can't rely on sha id info), I would like to have more "differential" way to distinguish prepared test builds. Considering that there are a perfect spot for time even on 96x16 screens, I hope it won't hurt. In addition, as you may know, a lot of timestamp build info for all kind of software usually contains not only date but time as well, so it's a well known common practice:

$ uname -a
Linux cs-default 6.1.58+ #1 SMP PREEMPT_DYNAMIC ** Mon Jan 29 15:19:25 UTC 2024 ** x86_64 GNU/Linux

@ia ia added Build System make/bash/python, github CI/CD & pals. Documentation Markdown, ReadTheDocs & GH Pages. labels Feb 13, 2025
@ia ia requested review from Ralim and discip February 13, 2025 04:58
@ia ia self-assigned this Feb 13, 2025
@ia ia enabled auto-merge February 13, 2025 05:00
@paulfertser
Copy link
Contributor

Hello,
This is indeed a nice feature for debugging and I see you're extending the timestamp that's already there. However, that got me thinking about reproducible builds.
Can you please consider following https://reproducible-builds.org/docs/source-date-epoch/ to make it easier for those who might want to make the build fully reproducible later?

@paulfertser
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System make/bash/python, github CI/CD & pals. Documentation Markdown, ReadTheDocs & GH Pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants