Skip to content

Commit

Permalink
Swap dependency installation in CI
Browse files Browse the repository at this point in the history
The `npx playwright install --with-deps` command was producing this warning:

```
WARNING: It looks like you are running 'npx playwright install' without first
installing your project's dependencies.
```

so this change addresses that by running `npm ci` before running
`npx playwright install --with-deps`.

Refs: https://github.com/RaisinTen/perftrace/actions/runs/10806970534/job/30191988723#step:4:7
Signed-off-by: Darshan Sen <[email protected]>
  • Loading branch information
RaisinTen committed Sep 16, 2024
1 parent ff84ce8 commit 641a85b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install Playwright Browsers
run: npx playwright install --with-deps
- name: Install dependencies
run: npm ci
- name: Install Playwright Browsers
run: npx playwright install --with-deps
- run: npm test

0 comments on commit 641a85b

Please sign in to comment.