Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vs 2019 support #35

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Vs 2019 support #35

merged 3 commits into from
Apr 9, 2019

Conversation

nazarenomanco
Copy link
Member

@nazarenomanco nazarenomanco commented Apr 6, 2019

@RadicalFx/radical-maintainers please check if there is something to fix.
The packege works on my VS2019.

P.S. Do we have to put Radical as Prerequisite on your opinion?

Related to #34

@mauroservienti
Copy link
Member

@nazarenomanco looks good to me. I simplified the .gitignore file. Be careful now that you might have detritus in you src directory.

P.S. Do we have to put Radical as Prerequisite on your opinion?

What do you mean?

@nazarenomanco
Copy link
Member Author

@mauroservienti if I use the package to add a Radical View/VM and I do not have added Radical to my solution I'll get a compilation error.
I'm wondering if we can put a "prerequisite" if Radical packages are not installed.

@mauroservienti
Copy link
Member

AFAIK no, file templates don’t have dependencies. The project template has dependencies. Happy to be proved wrong though, can you investigate if there in an option to define dependencies for file templates?

@nazarenomanco
Copy link
Member Author

nazarenomanco commented Apr 7, 2019

@mauroservienti at the moment the possibilities are:

  1. pack together with the project template the needed nuget packages
  2. setup a "wizard" that at the moment is not a supported solution but a "workaround if you really need it"
  3. leave in this way (if I add a Radical Windows I should still have created a project with Radical references)

@mauroservienti
Copy link
Member

I vote for number 3.

@mauroservienti mauroservienti merged commit 83028e4 into master Apr 9, 2019
@mauroservienti mauroservienti deleted the vs-2019-support branch April 9, 2019 19:09
@nazarenomanco nazarenomanco mentioned this pull request Apr 9, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants